Fixed quaternion default value issue. Added Test

[asisbot]

No description provided.

[megawac]

You may also have to change this test (/~https://github.com/RobotWebTools/roslibjs/blob/develop/test/examples/tf.example.js#L18)

[rctoris]

Single quotes are used in all of the ros JS code which will also cause the build to fail :)

[asisbot]

When I ran test/examples/tf.example.js using setup_examples.sh and karma start, all tests in tf.example.js were successful.

Do you mean fix tf.example.js#L18 or add new tests to tf.example.js ?

[megawac]

https://travis-ci.org/RobotWebTools/roslibjs/builds/36987963#L1441

To run tests

cd /path/to/roslib
sh test/examples/setup_examples.sh
npm run test-examples

[T045T]

That failure is because the turtle_tf_broadcaster nodes crashed, probably because of a bad lookup.
They should publish a quaternion with w = 1, {w : 0, x : 0, y : 0, z : 0} is an invalid quaternion anyway.

[rctoris]

Re-triggered after some build fixes were added. Travis output now shows the test that fails with the new default values: https://travis-ci.org/RobotWebTools/roslibjs/builds/36987963#L1437

[asisbot]

I found a problem with .travis.yml. According to the .travis.yml file, ros-hydro-geometry-tutorials is not installed into the travis environment. It means turtle_tf package roslaunched from setup_examples.sh is not installed, either. So, no tf between /world and /turtle1 is published by setup_examples.sh in travis. I could reproduce the same error in my environment by following the steps defined in the .travis.yml. Then, after I apt-get installed ros-hydro-geometry-tutorials, I confirmed that all tests succeeded. (However, fibonacci tests were very unstable as issued #114.)

The pull request #119 replaces "roslaunch turtle_tf turtle_tf_demo" with static_transform_publisher. So, after this pull request is merged, all tests will become successful.

[T045T]

Good catch! Right now, the build seems to be broken because the current rosbridge package doesn't work right. As soon as the new version has propagated to the package sources, we should finally be able to get this to pass and merge it :)