German Open Feedback for Stickler for the Rules #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johaq
commented
Apr 23, 2024
johaq
commented
- Showing logs afterwards is not sufficient. Robot needs to communicate during test
- Added decision from Bordeaux that a robot talking to no one in the arena about the rule does not incur an additional penalty.
- Added ranges for the number of rulebreakers. These are usually decided on and applied on site in the TLM so why not just have them in the rules
- Added clarification on how confirming a rule being followed works
LeroyR
approved these changes
Apr 23, 2024
johaq
requested review from
YuqianJiang,
LeroyR,
hawkina,
PetervDooren,
LeanderVonSeelstrang,
myszzka96,
sunava and
akinobu1998
akinobu1998
approved these changes
May 3, 2024
hawkina
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.