Prop anims with 'eventlock' now remain active if player leaves vehicle (+multiplayer). #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even if player exits the vehicle, the animations remain active. Also the code is now cleaner - user inputs are tracked in simulation realm (see `Actor::UpdatePropAnimInputEvents()`) , then recorded to simbuffer - gfx realm only applies the states to OGRE (see `GfxActor::UpdatePropAnimations()`). - as result, GfxScene::UpdateScene() no longer needs to track which actors are linked to player actor - it's now done in simulation as with all other updates. Code changes: * RigDef_File.h: renamed `event` to `event_name` to get rid of VisualStudio highlighting it as keyword, and it's also more specific. * SimData.h: added `struct PropAnimKeyState` to track user inputs within simulation step, as it should be. * GfxData.h: removed obsolete fields from `struct PropAnim`. * Actor.h/cpp: added prop anim keystate array + Update() function. * ActorSpawner.cpp: when prop animation uses 'event:source', register the keystate with the actor. * GameContext.cpp: update anim key states for player actor and all connected actors. * GfxActor.cpp: use simbuffer to fetch anim key states from simulation.
RoRnet bumped.
ohlidalp
changed the title
tritonas00
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kindly requested from Discord by Flip889#6304 and BRobinson#9257
As a bonus, key-triggered prop animations now propagate over network:
RoRnet was bumped to .44