Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prepaid as a period type #4782

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Add prepaid as a period type #4782

merged 3 commits into from
Feb 18, 2025

Conversation

greenietea
Copy link
Contributor

@greenietea greenietea commented Feb 12, 2025 •
edited
Loading

Add prepaid as a period type like we have done in android.

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-android and hybrids

Motivation

Description

@greenietea greenietea added the pr:fix A bug fix label Feb 12, 2025
@greenietea greenietea force-pushed the add-prepaid-as-period-type branch 2 times, most recently from eb1ba61 to 538cfd6 Compare February 13, 2025 20:27
@greenietea greenietea force-pushed the add-prepaid-as-period-type branch from 538cfd6 to 9921c0f Compare February 18, 2025 16:41
@greenietea
Copy link
Contributor Author

@RCGitBot please test

@greenietea greenietea marked this pull request as ready for review February 18, 2025 18:54
@greenietea greenietea requested a review from a team February 18, 2025 18:55
tonidero
tonidero approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @greenietea!! Looks great!

@greenietea greenietea merged commit 880c441 into main Feb 18, 2025
38 checks passed
@greenietea greenietea deleted the add-prepaid-as-period-type branch February 18, 2025 21:16
This was referenced Feb 19, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonidero tonidero tonidero approved these changes

Assignees
No one assigned
Labels
pr:fix A bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greenietea @tonidero