Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Preview Mode: app user ID #4725

Merged
merged 4 commits into from
Jan 30, 2025
Merged

UI Preview Mode: app user ID #4725

merged 4 commits into from
Jan 30, 2025

Conversation

ajpallares
Copy link
Member

@ajpallares ajpallares commented Jan 28, 2025

Checklist

  • If applicable, unit tests

Motivation

The SDK uses a fixed, specific user ID when initialized in UI preview mode in order to prevent cluttering usage statistics for the developer

Description

When using the UI preview mode introduced in #4714, the SDK will force the appUserID to be "$RC_PREVIEW_MODE_USER".

@ajpallares ajpallares marked this pull request as ready for review January 29, 2025 08:56
@ajpallares ajpallares changed the title Pallares/UI preview mode+user UI Preview Mode: app user ID Jan 29, 2025
@ajpallares ajpallares requested review from a team and aboedo January 29, 2025 08:57
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of smallish comments

* Change default appUserID for UI Preview mode.
* Add debug log regarding the use of UI Preview mode user ID.
@ajpallares ajpallares requested review from tonidero and a team January 29, 2025 11:06
@ajpallares ajpallares merged commit 788b627 into main Jan 30, 2025
8 of 10 checks passed
@ajpallares ajpallares deleted the pallares/uiPreviewMode+userID branch January 30, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants