Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve syntax for CommonLocalizedString #4688

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Improve syntax for CommonLocalizedString #4688

merged 3 commits into from
Jan 21, 2025

Conversation

facumenzella
Copy link
Contributor

Motivation

The previous syntax made the whole dance too verbose:

- .navigationTitle(localization.commonLocalizedString(for: .purchaseHistory))
+ .navigationTitle(localization[.purchaseHistory])

This simplifies it 💅

This only affects CustomerCenter

ajpallares
ajpallares approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@ajpallares ajpallares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Much cleaner this way 👏

@facumenzella facumenzella enabled auto-merge (squash) January 21, 2025 11:02
@facumenzella facumenzella added pr:other and removed pr:feat A new feature labels Jan 21, 2025
@facumenzella facumenzella disabled auto-merge January 21, 2025 11:13
@facumenzella facumenzella enabled auto-merge (squash) January 21, 2025 11:13
@facumenzella facumenzella merged commit 377a575 into main Jan 21, 2025
10 checks passed
@facumenzella facumenzella deleted the feat/add-subscript-localization branch January 21, 2025 11:20
@vegaro vegaro changed the title refactor: [CustomerCenter] Improve syntax for CommonLocalizedString Improve syntax for CommonLocalizedString Jan 21, 2025
@RCGitBot RCGitBot mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpallares ajpallares ajpallares approved these changes

Assignees
No one assigned
Labels
feat:Customer Center pr:other pr:RevenueCatUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facumenzella @ajpallares @vegaro