[Trusted Entitlements] Do not clear CustomerInfo upon enabling Trusted Entitlements #4671
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonidero
force-pushed
the
keep-unverified-customer-info-upon-enabling-trusted-entitlements
branch
from
3c66118 to
eebd5fe
Compare
ajpallares
approved these changes
Jan 15, 2025
ajpallares
reviewed
Jan 15, 2025
ajpallares
approved these changes
Jan 15, 2025
JayShortway
approved these changes
Jan 16, 2025
| case .invalidating_cached_customer_info: | ||
| return "Detected unverified cached CustomerInfo but verification is enabled. Invalidating cache." | ||
| case .invalidating_http_cache: | ||
| return "Detected unverified cached CustomerInfo but verification is enabled. Invalidating HTTP cache." |
There was a problem hiding this comment.
We're calling this ETag cache in Android, also in public logs. Ideally we're consistent both publicly and internally, but at least publicly imo 😄
tonidero
deleted the
keep-unverified-customer-info-upon-enabling-trusted-entitlements
branch
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until now, when devs enabled Trusted Entitlements, we would clear the cached
CustomerInfoand customers would need to refetch the latest value from the server, which could potentially cause delays and/or losing access temporarily.With this PR, we won't be clearing the cached CustomerInfo anymore. Instead, we would return the cached customer info, which will have a
VerificationResultofNOT_REQUESTED.iOS equivalent of RevenueCat/purchases-android#2049