fix build warnings #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssed warnings for missing methods that are implemented in the main SDK
vegaro
approved these changes
Dec 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a couple of build warnings:
One is because we were missing a header (
RCTransactions+HybridAdditions) in the umbrella headerThe other one is trickier: it's because we have a few methods that we want to have private in the main SDK, but that should be usable by the hybrid sdks. Their implementation relies on private stuff from the main SDK, but since hybridCommon uses it just as any app using the sdk would, it can't access the private files.
The current solution is to have the implementation live in the main SDK, and just declare it in a header for our use. This triggers a build warning, however, so I'm supressing the build warning specifically for that file in this PR.