Adds callback cache identity #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
approved these changes
Sep 15, 2021
Comment on lines
+56
to
+61
| @get:Synchronized @set:Synchronized | ||
| @Volatile var createAliasCallbacks = mutableMapOf<CallbackCacheKey, MutableList<CreateAliasCallback>>() | ||
|
|
||
| @get:Synchronized @set:Synchronized | ||
| @Volatile var identifyCallbacks = mutableMapOf<CallbackCacheKey, MutableList<IdentifyCallback>>() | ||
|
|
There was a problem hiding this comment.
it's fine for now, but we really should try to make this a common thing, which we can reuse easily. Perhaps at the HTTPClient level
vegaro
added a commit
that referenced
this pull request
Sep 15, 2021
* adds callback cache to identity and createAlias * add log * use debuglog instead of Log * adds a delay # Conflicts: # common/src/main/java/com/revenuecat/purchases/common/Backend.kt # common/src/test/java/com/revenuecat/purchases/common/BackendTest.kt # strings/src/main/java/com/revenuecat/purchases/strings/NetworkStrings.kt
This was referenced Sep 15, 2021
Merged
beylmk
reviewed
Sep 21, 2021
| @@ -280,7 +291,11 @@ class Backend( | |||
| onSuccessHandler: () -> Unit, | |||
| onErrorHandler: (PurchasesError) -> Unit | |||
| ) { | |||
| enqueue(object : Dispatcher.AsyncCall() { | |||
| val cacheKey = listOfNotNull( | |||
| appUserID, | |||
There was a problem hiding this comment.
looks like tests only check that we don't repeat the call if both are the same. maybe we can add a test to confirm that if EITHER parameter has changed, we WILL repeat the call?
There was a problem hiding this comment.
Sure, that's a good catch. Want me to write it or you take care of it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting some customers calling alias or identify too often. Sometimes with the same parameters.
Something I have noticed while trying to replicate the issue with this code:
Is that most of the times the code will enter in the
ifclause. The reason is that we only update the appUserID when the API call has come back with a result, so the check would most of the times evaluate to the same.In this PR, I have added the same caching mechanism we currently have for other API calls. It prevents the same calls being executed at the same time with the same parameters. This should prevent apps from hitting our servers with
/aliasand/identifycalls that look the same too often.