-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to RxJava 1.1.5 #194
Bump to RxJava 1.1.5 #194
Conversation
zsxwing
commented
Jun 6, 2016
- Bump to RxJava 1.1.5
- Add missing operators
- Bump to RxJava 1.1.5 - Add missing operators
I see that more and more
Will there be even more later? |
It will become too verbose for RxJava considering Java doesn't have the extension methods.
Java doesn't have the default value. However, both them are supported in Scala. For the default values, I remember when we use overload, default value, currying and implicit together, the compiler will be crazy and not be able to resolve the correct method. So I prefer the extension method idea. |
I'm a bit confused, why you are mentioning extension methods? Do you mean extension methods as defined here? The approach used in BlockingObservable does not require extension methods at all. |
Yep. |
Ok, but what if we call it |
Sounds great. I will update the PR. |
* [[Observable]]s by means of the given aggregation function | ||
* @see <a href="http://reactivex.io/documentation/operators/combinelatest.html">ReactiveX operators documentation: CombineLatest</a> | ||
*/ | ||
def combineLatestDelayError[T, R](sources: Iterable[Observable[T]])(combineFunction: Seq[T] => R): Observable[R] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combineLatestDelayError
is still in Observable
object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess Observable.combineLatestDelayError
is better than ErrorDelayingObservable.combineLatest
(unless there will be many more static xxxDelayError
methods, maybe)
@samuelgruetter updated. |
"concatDelayError(Observable[_ <: Observable[_ <: T]])" -> "concatDelayError(<:<[Observable[T], Observable[Observable[U]]])", | ||
"concatDelayError(Iterable[_ <: Observable[_ <: T]])" -> "[use `iter.toObservable.concatDelayError`]", | ||
"concatDelayError(Observable[_ <: Observable[_ <: T]])" -> "[use `delayError.concatDelay(<:<[Observable[T], Observable[Observable[U]]])`]", | ||
"concatDelayError(Iterable[_ <: Observable[_ <: T]])" -> "[use `iter.toObservable.delayError.concatDelay`]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be concat
instead of concatDelay
, I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be concat instead of concatDelay, I guess?
Fixed
LGTM |