Move examples #168
Merged
Move examples #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks :-) But now all pages linking to /~https://github.com/ReactiveX/RxScala/blob/0.x/examples/src/test/scala/rx/lang/scala/examples/RxScalaDemo.scala will have to be updated. For instance the README or the RxScala website and probably many more... I'd try to update as many as possible of them, but we'll probably miss some, so I'd suggest that you add a commit to this PR which adds an |
* Move examples * Fix small missing java conversion in scaladoc
hermanbanken
force-pushed
the
0.x
branch
3 times, most recently
from
baef021 to
b89fd83
Compare
RxScalaDemo was moved to not longer be in rx.lang.scala, but references to this file may exist over the wiki and internet. Therefore this file is kept to guide users where to find it now. Fixes ReactiveX#167
|
@samuelgruetter I included a file at the original RxScalaDemo.scala's location and updated some Markdown files as well. |
|
LGTM, thanks 👍 |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the examples so that they no longer have access to private methods in the rx.lang.scala package. These examples being in the same package already made
TestScheduler.scalanot work out of the box.As a novice RxScala-test-writer 😅 I did not understand at first that some JavaConversion was going on, as I missed that the mock class was mocking the Java variant of Observer.