Update the out-of-date example in "Notification" doc #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After an update on OnCompleted (ebff7cc) the example does not work if used without a small change for pattern matching
| @@ -73,7 +73,7 @@ sealed trait Notification[+T] { | |||
| * import Notification._ | |||
| * Observable(1, 2, 3).materialize.subscribe(n => n match { | |||
| * case OnNext(v) => println("Got value " + v) | |||
| * case OnCompleted() => println("Completed") | |||
| * case OnCompleted => println("Completed") | |||
zsxwing
changed the title
changing Observable(1, 2, 3) to Observable.just(1, 2, 3) in the example
zsxwing
added a commit
that referenced
this pull request
May 7, 2015
Update the out-of-date example in "Notification" doc
|
LGTM. Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an update on OnCompleted (elegoff@ebff7cc) the example does not work if used without a small change for pattern matching