Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): can not mark view as read #2909

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Feb 28, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:50am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Feb 28, 2025 7:50am

@follow-reviewer-bot
Copy link

Suggested PR Title:

refactor: update imports in MarkAllAsReadDialog and atoms

Change Summary:
Refactor imports to improve module organization and clarity.

Code Review:

  • File: MarkAllAsReadDialog.tsx, Line 6
    Changing the import useSelectedView from "../feed-drawer/atoms" to "../screen/atoms" suggests that functionality has been moved to a new module. However, based on the surrounding context, there is no confirmation in this pull request whether useSelectedView exists and is correctly implemented in ../screen/atoms. You should ensure that the new import path is valid and that the module in ../screen/atoms properly exports useSelectedView. If the function does not exist or isn't exported correctly, this change will cause runtime errors.

  • File: feed-drawer/atoms.ts, Line 4
    The addition of /* eslint-disable unused-imports/no-unused-vars */ disables lint rules for unused imports or variables across the file. While this might resolve linting errors, it is not ideal as it lowers the code quality by permitting unused code that could lead to unnecessary clutter or confusion in the future. It would be better to remove unused imports/variables or resolve the specific linting issue instead of disabling the lint rule for the entire file. Restrict the use of eslint-disable to specific problematic lines rather than the entire file, if possible.

  • File: feed-drawer/atoms.ts, Line 10
    Changing useSelectedView from a named export to a local function-only usage may affect any existing modules or components that rely on this function. The pull request does not include information about other parts of the codebase that might be importing useSelectedView from this location. Ensure that removing it as an export does not break dependencies elsewhere in the application.

Recommended Actions:

  1. Verify that useSelectedView in ../screen/atoms is properly implemented and exported before redirecting the import in MarkAllAsReadDialog.tsx.
  2. Avoid disabling lint rules for the entire file. Instead, fix or handle the unused imports/variables issue in feed-drawer/atoms.ts. If absolutely necessary, use targeted eslint-disable comments for specific instances.
  3. Confirm that the change from an exported function to a local function for useSelectedView in feed-drawer/atoms.ts does not impact other parts of the codebase.

@hyoban hyoban enabled auto-merge (squash) February 28, 2025 07:49
@hyoban hyoban merged commit ab27ab8 into dev Feb 28, 2025
10 of 11 checks passed
@hyoban hyoban deleted the fix/can-not-mark-view-as-read branch February 28, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant