Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make icon center when media has play status #2898

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Conversation

kovsu
Copy link
Contributor

@kovsu kovsu commented Feb 27, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Before:

CleanShot 2025-02-27 at 09 33 44

After:

CleanShot 2025-02-27 at 09 33 34

Demo Video (if new feature)

Linked Issues

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

@follow-reviewer-bot
Copy link

Thank you for your contribution. We will review it promptly.

Copy link

vercel bot commented Feb 27, 2025

@kovsu is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@follow-reviewer-bot
Copy link

Suggested PR Title:

fix: enhance audio cover animation on play status toggle

Change Summary:
Updated audio cover animation for improved UX visibility.

Code Review:

  • File: apps/renderer/src/modules/entry-column/templates/list-item-template.tsx
    • Line 285: The conditional class merging now introduces redundant CSS styles when playStatus is true (-translate-y-2 opacity-100). Since this is also applied by the isMobile condition, it creates potential overlap and inconsistency. To prevent duplication and ensure maintainability, consider refactoring the logic to ensure the classnames are applied cleanly without redundancy. For example, you can adjust the logic to avoid applying the same classes twice in different conditions.

Please address this duplication to enhance the clarity and efficiency of the class handling logic.

@Innei Innei merged commit 39039e8 into RSSNext:dev Feb 27, 2025
3 of 6 checks passed
@follow-reviewer-bot
Copy link

Thank you @kovsu for your contribution! 🎉

Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪

@kovsu kovsu deleted the fix-1 branch February 27, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants