-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NACSouthGermanyMediaLibraryBridge] Add new bridge #3636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request artifacts
|
Apparently the website is protectecd by CloudFlare. Locally for me, this bridge works fine. Does that mean this cannot be merged? |
They probably blacklist vps ip ranges. We can merge but maybe add a note in the bridge description about this. |
Done. |
dvikan
pushed a commit
to dvikan/rss-bridge
that referenced
this pull request
Sep 13, 2023
* Init nac south bridge * Rename bridge * Refactoring * Refactor * Fix formatting * Fix testing errors * Change constants * Update logo * Remove author omission in descriptions * Fix comment * Add maintainer * Rename bridge * Add technical note to bridge description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3635.
Since the items on https://www.nak-sued.de/mediathek/rundfunksendungen-auf-bayern-2/aktuelle-sendungen and https://www.nak-sued.de/mediathek/rundfunksendungen-auf-swr1/aktuelle-sendungen etc. are very spread out, we need to make a considerable amount of web requests. Currently (at the moment of writing this pull request), a call to
NACSouthGermanyMediaLibraryBridge::collectData
leads to 44 web requests.