-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GiteaBridge] Rewrite to decouple from Gogs and add contexts #2718
Conversation
Pull request artifacts
|
Great work, thanks! Right now, the example values dont produce anything since there is not gitea/gitea on the tryout instance. There is the prepared repo on https://gitea.com/gitea/gitea but that's empty so it wont generate anything for most of the contexts. You should be able to use their helm charts repo though, it has issues, PRs, tags, releases etc: Can you adapt the examplevalues pls? |
Good idea @Bockiii ! I've replaced the |
There are a few debug notices for the single issue and single pr contexts, can you check if you can get rid of those? other than that, it looks fine to me. Just one consistency note: You switch between " - text" and "text - " (for example: "helm-chart Releases" and "Tags for helm-chart". Maybe set those up consistently, but it's not super important. |
Good catch, fixed both. Regarding the notices, it's about code reviews (an example), which are a bit finicky. For now the bridge will only handle comments in code reviews, and not the whole code-review block. I think the titles are a bit better now : |
Alright, looks good to me. Thx |
Continuation of #2670.
This PR makes separates GiteaBridge from GogsBridge, and make it compatible with Gitea 1.0 and 1.17 (at least).
If a compatibility issue on a version between those two, I'd be happy to fix it.
It also implements the Tags, Pull Request, and Single pull request bridge context.