Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule34pahealBridge] Use full size image #1775

Merged
merged 1 commit into from
Nov 11, 2020
Merged

[Rule34pahealBridge] Use full size image #1775

merged 1 commit into from
Nov 11, 2020

Conversation

dawidsowa
Copy link
Contributor

Paheal has "Image Only" links, so IMO there's no reason, not to use them.

As a bonus, this commit fixes tags.

protected function getItemFromElement($element){
$item = array();
$item['uri'] = $this->getURI() . $element->href;
$item['uri'] = rtrim($this->getURI(), '/') . $element->find('.shm-thumb-link', 0)->href;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is defaultLinkTo for fixing URLs. But it looks like it will be more complicated to use it

rss-bridge/lib/html.php

Lines 96 to 107 in ff98efe

/**
* Convert relative links in HTML into absolute links
*
* This function is based on `php-urljoin`.
*
* @link /~https://github.com/plaidfluff/php-urljoin php-urljoin
*
* @param string|object $content The HTML content. Supports HTML objects or string objects
* @param string $server Fully qualified URL to the page containing relative links
* @return object Content with fixed URLs.
*/
function defaultLinkTo($content, $server){

@em92 em92 merged commit 6baf64f into RSS-Bridge:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants