Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/stm32f429i-disc1: fix touch screen axis [backport 2024.10] #21014

Conversation

benpicco
Copy link
Contributor

Backport of #21007

Contribution description

This patch fixes a missmatch between the LCD and touch drivers' coordinate systems.

Testing procedure

Build and flash with make -C tests/pkg/lvgl_touch/ flash, and observe the test works as intended with this patch, but not without it.

Issues/PRs references

none known

This patch fixes a missmatch between the LCD and touch drivers'
coordinate systems.

(cherry picked from commit 05bc405)
@benpicco benpicco added Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Nov 20, 2024
@benpicco benpicco requested a review from Enoch247 November 20, 2024 22:29
Copy link
Contributor

@Enoch247 Enoch247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested on my board and it works.

@Enoch247
Copy link
Contributor

I haven't merged many PRs yet. Should I merge this? Any special instructions?

@riot-ci
Copy link

riot-ci commented Nov 21, 2024

Murdock results

✔️ PASSED

7503587 boards/stm32f429i-disc1: fix touch screen axis

Success Failures Total Runtime
554 0 554 04m:40s

Artifacts

@maribu maribu added this pull request to the merge queue Nov 21, 2024
Merged via the queue into RIOT-OS:2024.10-branch with commit 2699f21 Nov 21, 2024
30 checks passed
@benpicco benpicco deleted the backport/2024.10/fix-stm32f429i-disc1-touch branch November 21, 2024 10:17
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants