makefiles/arch/native: don't be pedantic #20873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't enable this on any other architecture. -pedantic doesn't give us any more beneficial wanrings, only warns about language extensions that are implemented by both GCC and Clang anyway. Since those are the only compilers we are targeting, we can just make use of them to make our lives easier.
github-actions
bot
added
Platform: native
benpicco
added
Process: needs >1 ACK
github-actions
bot
added
the
Process: missing approvals
maribu
approved these changes
Sep 26, 2024
Teufelchen1
approved these changes
Oct 1, 2024
benpicco
added
Area: build system
github-actions
bot
removed
the
Process: missing approvals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
We don't enable this on any other architecture.
-pedanticdoesn't give us any more beneficial warnings, only warns about language extensions that are implemented by both GCC and Clang anyway.Since those are the only compilers we are targeting, we can just make use of them to make our lives easier.
Testing procedure
Code should still compile as before.
We can likely drop all those
as a follow-up.
Issues/PRs references