Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devTasks #1200

Merged
merged 3 commits into from
Sep 18, 2022
Merged

devTasks #1200

merged 3 commits into from
Sep 18, 2022

Conversation

ManuelHentschel
Copy link
Member

This PR removes two compiled .js files (keeping only their source .ts files) and updates the vscode tasks so that they generate those files for debugging/compilation.

Copy link
Member

@renkun-ken renkun-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkun-ken renkun-ken merged commit a481265 into REditorSupport:master Sep 18, 2022
@renkun-ken
Copy link
Member

renkun-ken commented Sep 18, 2022

The following files are generates as untracked each time I debug the extension:

html/help/script.js
html/httpgd/index.js

@ManuelHentschel Maybe we should ignore these files in a gitignore?

@ManuelHentschel ManuelHentschel deleted the devTasks branch September 18, 2022 12:17
@ManuelHentschel
Copy link
Member Author

The following files are generates as untracked each time I debug the extension:

html/help/script.js
html/httpgd/index.js

@ManuelHentschel Maybe we should ignore these files in a gitignore?

Done in 7ddd0d5

@renkun-ken
Copy link
Member

Seems html/session/webview/observer.js is ignored too. Not sure if it should be?

@ManuelHentschel
Copy link
Member Author

Seems html/session/webview/observer.js is ignored too. Not sure if it should be?

Files that are already tracked (like observer.js) shouldn't be affected by new .gitignore entries. You can check that e.g. by modifying the file and running git status (which correctly shows observer.js for me).

@renkun-ken
Copy link
Member

OK. Thanks for reminding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants