Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated matchms remove spectra tool #553

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

hechth
Copy link
Member

@hechth hechth commented Jun 3, 2024

  • removing now spectra with 0 value as retention index
  • Fixed bug related to variables and inchikey removal - the string matching logic had some bugs
  • simplified logic

@hechth hechth requested a review from zargham-ahmad June 3, 2024 12:28
Copy link
Collaborator

@zargham-ahmad zargham-ahmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hechth hechth merged commit 2abca92 into RECETOX:master Jun 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants