Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated waveica for new outputs from recetox-aplcms #378

Merged
merged 8 commits into from
Jun 23, 2023
Merged

Updated waveica for new outputs from recetox-aplcms #378

merged 8 commits into from
Jun 23, 2023

Conversation

zargham-ahmad
Copy link
Collaborator

This PR includes the following:

  • Added data transpose option so the new outputs from recetox-aplcms can be used
  • Added verify_column_types function to check if the columns are of the correct type
  • Added test and testdata for transpose case
  • Fixed some param calls in the test (filter_length -> wavelet_length)
  • added group var in waveica_singlebatch function which was not there but used
  • Bump version

closes #365

@zargham-ahmad zargham-ahmad requested a review from hechth June 22, 2023 11:58
@hechth hechth requested a review from xtrojak June 22, 2023 12:27
hechth
hechth reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only add WaveICA to bio.tools and then add the crossref here and we're done :)

@zargham-ahmad
Copy link
Collaborator Author

LGTM - only add WaveICA to bio.tools and then add the crossref here and we're done :)

added in a54098b

@zargham-ahmad zargham-ahmad mentioned this pull request Jun 22, 2023
Closed
12 tasks
xtrojak
xtrojak approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@xtrojak xtrojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except minor issues looks good to me.

@hechth hechth merged commit 77bea6c into RECETOX:master Jun 23, 2023
@zargham-ahmad zargham-ahmad deleted the issue365 branch December 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hechth hechth hechth left review comments

@xtrojak xtrojak xtrojak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check and update waveica for new outputs from recetox-aplcms and RAMClustR
3 participants
@zargham-ahmad @hechth @xtrojak