Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAMClustR: update to 1.3.0 #364

Merged
merged 16 commits into from
Jun 15, 2023
Merged

RAMClustR: update to 1.3.0 #364

merged 16 commits into from
Jun 15, 2023

Conversation

zargham-ahmad
Copy link
Collaborator

@zargham-ahmad zargham-ahmad commented May 31, 2023

This PR includes the following:

  • updated the ramclustr package to 1.3.0
  • added input option for recetox-aplcms
  • rewrote the wrapper and use the individual steps
  • added test for the df version

note: normalization method qc and quantile will not work until the new version of ramclustr cbroeckl/RAMClustR#44

closes #335

@zargham-ahmad zargham-ahmad requested a review from hechth May 31, 2023 16:56
@hechth
Copy link
Member

hechth commented Jun 1, 2023

@zargham-ahmad please also add the option for qc normalization to the wrapper

@zargham-ahmad zargham-ahmad marked this pull request as ready for review June 12, 2023 14:29
@hechth hechth merged commit 981ab05 into RECETOX:master Jun 15, 2023
@zargham-ahmad zargham-ahmad deleted the issue335 branch December 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAMClustR: update to 1.3.0
2 participants