Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSME matchms logging level #259

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Conversation

xtrojak
Copy link
Contributor

@xtrojak xtrojak commented Apr 22, 2022

Set matchms logging level to ERROR to avoid extensive messages in stdout. This required to add matchms as MSME wrapper dependency.

Close #255.

@xtrojak xtrojak requested a review from hechth April 22, 2022 12:11
@@ -8,6 +8,7 @@

<requirements>
<requirement type="package" version="@TOOL_VERSION@">msmetaenhancer</requirement>
<requirement type="package" version="0.14.0">matchms</requirement>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, its installed with MSME.

Comment on lines +20 to 23
set_matchms_logger_level("ERROR")
# import .msp file
app.load_spectra(args.input_file, file_format='msp')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The level can be returned back to WARNING after loading the spectra.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I set it back to WARNING before curation in d3e8037.

@hechth hechth merged commit fc4fc95 into RECETOX:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSME: Change log level to warning when reading files
2 participants