-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uses of Autohook from dedicated.cpp
#799
Remove uses of Autohook from dedicated.cpp
#799
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Do we have an easy way to script crash via some script function? Or do we need to write like a broken mod to test this >.< |
The latter I think. Iirc any error induced by a simple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in testing
Code review:
o_p
so any times where the old AUTOHOOK was calling the original function it should now be calling that instead.h_
so any times where we would be wanting to call the hooked function from other functions should now be calling that insteadTesting: