Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for r2/maps folder #575

Merged
merged 4 commits into from
Oct 15, 2023
Merged

Add check for r2/maps folder #575

merged 4 commits into from
Oct 15, 2023

Conversation

H0L0theBard
Copy link
Contributor

Adds a fix so that #564 can be re-merged

Testing Instructions

  1. Rename r2/maps
  2. Run maps * in the console

If the game does not die, 🎉.
It should just print the maps found from the vpks.

Jan200101
Jan200101 approved these changes Oct 14, 2023
View reviewed changes
Copy link
Contributor

@Jan200101 Jan200101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed working
code is clean and simple, checks if the folder exists.

@Jan200101 Jan200101 added the READY TO MERGE This mergeable right now label Oct 14, 2023
@GeckoEidechse GeckoEidechse changed the title Add check for R2/maps folder Add check for r2/maps folder Oct 15, 2023
@itscynxx
Copy link
Contributor

It does in fact work properly in testing
I tested this of my own free will and there were no other factors in doing so

@GeckoEidechse
Copy link
Member

Merging based on reviews.

@GeckoEidechse GeckoEidechse merged commit f24089e into R2Northstar:main Oct 15, 2023
@GeckoEidechse GeckoEidechse mentioned this pull request Oct 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jan200101 Jan200101 Jan200101 approved these changes

Assignees
No one assigned
Labels
READY TO MERGE This mergeable right now
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@H0L0theBard @itscynxx @GeckoEidechse @Jan200101