refactor: use ptr_from_ref and ptr .cast()
#4240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
ptr-from-ref
branch
2 times, most recently
from
6cdbc75 to
d6ea3c1
Compare
mejrs
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Thanks, I much prefer this as well.
Also, we can use https://doc.rust-lang.org/std/primitive.pointer.html#method.cast_mut when we bump msrv next time :)
Icxolu
approved these changes
Jun 7, 2024
|
Yes, as well as |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
JRRudy1
added a commit
to JRRudy1/pyo3
that referenced
this pull request
Jun 8, 2024
…tr_from_ref` added in PR PyO3#4240. Updated `PyRefMut::as_super` to use this method instead of `as *mut _`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 9, 2024
* Added `PyRef::as_super` and `PyRefMut::as_super` methods, including docstrings and tests. The implementation of these methods also required adding `#[repr(transparent)]` to the `PyRef` and `PyRefMut` structs. * Added newsfragment entry. * Changed the `AsRef<U>`/`AsMut<U>` impls for `PyRef` and `PyRefMut` to use the new `as_super` methods. Added the `PyRefMut::downgrade` associated function for converting `&PyRefMut` to `&PyRef`. Updated tests and docstrings to better demonstrate the new functionality. * Fixed newsfragment filename. * Removed unnecessary re-borrows flagged by clippy. * retrigger checks * Updated `PyRef::as_super`, `PyRefMut::as_super`, and `PyRefMut::downgrade` to use `.cast()` instead of `as _` pointer casts. Fixed typo. * Updated `PyRef::as_super` and `PyRefMut::downgrade` to use `ptr_from_ref` for the initial cast to `*const _` instead of `as _` casts. * Added `pyo3::internal_tricks::ptr_from_mut` function alongside the `ptr_from_ref` added in PR #4240. Updated `PyRefMut::as_super` to use this method instead of `as *mut _`. * Updated the user guide to recommend `as_super` for accessing the base class instead of `as_ref`, and updated the subsequent example/doctest to demonstrate this functionality. * Improved tests for the `as_super` methods. * Updated newsfragment to include additional changes. * Fixed formatting. --------- Co-authored-by: jrudolph <jrudolph@anl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically these days I like to use
x.cast::<Y>()instead ofx as *const Yto perform pointer casting (and in many contexts it's also convenient to let type inference work on justx.cast(), which reads a lot nicer thanx as *const _). It also avoids const <-> mut casting by accident.I just discovered
ptr::from_refand am now similarly excited to replace&x as *const Xwithptr_from_ref(&x).... so this PR is just a few tidy-ups across the codebase!