Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge master into abi3 branch to resolve conflicts #1237

Merged
merged 21 commits into from
Oct 12, 2020

Conversation

alex
Copy link
Contributor

@alex alex commented Oct 12, 2020

No description provided.

davidhewitt and others added 19 commits October 10, 2020 06:08
contributing.md: add note on benchmarking
Move impl From for Py<T> to macros not used in rust-numpy
Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
Don't watch PYTHON_SYS_EXECUTABLE and PATH when unnecessary
Update environment setting for Github Actions API updates
Fix MSRV CI to correctly use MSRV
@@ -16,13 +20,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [Unreleased]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something's gone awry here - we've got two ## [Unreleased] sections. Might be worth holding a sec to fix until I merge #1236 and maybe merge some of the other PRs so the changelog clashes get smoothed out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that intentionally when I added the original changelog entry. This conflict didn't impact the changelog.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh, I see what happened. I'll fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, better now.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@davidhewitt
Copy link
Member

Ah interesting, looks like the fix to CI for MSRV has found something on this branch too! 😄

@alex
Copy link
Contributor Author

alex commented Oct 12, 2020

Indeed it did. Will fix.

@davidhewitt
Copy link
Member

Hmm that segfault is interesting 🤔

@alex
Copy link
Contributor Author

alex commented Oct 12, 2020

If it only reproduces on that one build, I'm not sure what to make of it :-/

@davidhewitt
Copy link
Member

I'm planning to drop Python 3.5 support very soon anyway (as part of 0.13). So if it's just that job let's merge this into abi3 branch anyway for now and I'll put up a PR to drop Python 3.5 support in the next day or two.

@alex
Copy link
Contributor Author

alex commented Oct 12, 2020

Sounds great.

@alex
Copy link
Contributor Author

alex commented Oct 12, 2020

yeah, just the one build :-/

@davidhewitt
Copy link
Member

👍

@davidhewitt davidhewitt merged commit 4298435 into PyO3:abi3 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants