Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix definition of _PyLong_AsByteArray #1029

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Fix definition of _PyLong_AsByteArray #1029

merged 1 commit into from
Jul 9, 2020

Conversation

davidhewitt
Copy link
Member

Correct FFI defintion from *const to *mut for _PyLong_AsByteArray, which writes to the pointer. Looks like there might have been some UB sneaking in there.

kngwyu
kngwyu approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt merged commit cfa5b2e into PyO3:master Jul 9, 2020
@davidhewitt davidhewitt deleted the asbytearray-mut branch July 9, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kngwyu kngwyu kngwyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @kngwyu