depend on fissix, lib2to3 fork Fixes #202

[graingert]

No description provided.

[graingert]

while fissix doesn't support running under py2.7 or py3.5 it will still parse the code from those versions

[graingert]

@takluyver ^

[jayvdb]

I've used this PR for rpm fixing @ https://build.opensuse.org/package/show/home:jayvdb:django/python-django-tdaemon .
Nice to have access to the extras of fissix.

[graingert]

@takluyver is this package no longer maintained?

[takluyver]

Sorry - I've more or less finished using python-modernize, so there's usually something either more urgent or more interesting to pay attention to. I think this was more or less what happened before when Armin Rigo maintained it. It's prone to this, being mostly a one-off tool that people use and then move on.

Anyway, the fissix changes look OK to me; I've made a few comments inline.

Do you want to be a co-maintainer? CC @daira @brettcannon

[graingert]

Sorry - I've more or less finished using python-modernize
Do you want to be a co-maintainer? CC @daira @brettcannon

@takluyver it might be worth transferring the project to @jazzband

[graingert]

@takluyver I've addressed your review comments

[takluyver]

Thanks, the changes look good. I'll do a squash merge to clean up the changes in comments that got reverted.

Jazzband is a neat idea, and I'd be open to it in principle. But I don't recognise most of the people involved (it looks like it's mostly come from the Django community, which I'm not familiar with), and python-modernize isn't my personal project, so I'd want to discuss with the other maintainers before transferring it. Whereas I recognise your name, and I'm happy enough to add another maintainer with just a heads-up to the other maintainers. So that's the easy option at the moment, if you're interested.

[graingert]

@takluyver yeah that makes sense, I'd be happy to review PRs if you add me and I find some time

You might also like to invite @jreese

[graingert]

@takluyver the @PyCQA is another place for group maintenance of Python packages (mainly focused on linting rather than Django)

[takluyver]

I've sent you an invite. What's your PyPI username?- I can add you on there too. @jreese, I'm happy to invite you too if you're interested.

I'm also happy in principle to turn it over to PyCQA, but I'd want the other current maintainers to agree on a move like that. And presumably it also depends on whether the people in PyCQA consider this in scope.

[jayvdb]

fwiw, I am a maintainer at @jazzband. It does have a lot of Django stuff, but also pip-tools, prettytable, tablib, contextlib2 and others. If you wanted to transfer it under their wing, I think it would make sense for jazzband to find a way to expand their permission system and website so that the project can stay here, allowing organic growth of its own team and only falling back on jazzband where necessary.

[takluyver]

Thanks @jayvdb. I'm not particularly concerned about the Github org - there's a single repo under the python-modernize org, and none of the maintainers have been very active recently, so I'd be happy enough to transfer it. But however it's technically done, I'd want @daira and @brettcannon to agree if some other group is going to adopt the codebase.

[graingert]

@takluyver I'm pretty sure modernize fits under the category of code quality tools: here's the request from the bandit project: https://mail.python.org/pipermail/code-quality/2018-February/000976.html

[graingert]

I've sent you an invite. What's your PyPI username?

I'm Thomas.Grainger on pypi

[takluyver]

Thanks, I've added you on PyPI. I've also emailed Daira & Brett to ask about passing the project on to another group.