Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Initial Overlay #904

Merged
merged 4 commits into from
Jun 3, 2020
Merged

Fix Initial Overlay #904

merged 4 commits into from
Jun 3, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Jun 1, 2020 •
edited
Loading

Changes

  • use hooks
  • fixed: overlay wasn't removing the main component and just pushing them to the bottom

Screen Shot 2020-06-01 at 2 46 03 PM

- adjusted spacing so the snippet block isn't cut short on the overlay

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl temporarily deployed to posthog-fix-overlay-uqozaahkoz June 1, 2020 18:49 Inactive
@timgl
Copy link
Collaborator

timgl commented Jun 2, 2020

Merge conflicts due to hot module reload that was just merged

@timgl timgl had a problem deploying to posthog-fix-overlay-uqozaahkoz June 2, 2020 12:57 Failure
@timgl timgl had a problem deploying to posthog-fix-overlay-uqozaahkoz June 2, 2020 13:00 Failure
@timgl timgl temporarily deployed to posthog-fix-overlay-uqozaahkoz June 2, 2020 15:12 Inactive
@timgl timgl merged commit 5cb8e9c into master Jun 3, 2020
@timgl timgl deleted the fix-overlay branch June 3, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDsCODE @timgl