Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property key descriptions to breakdown filter #886

Merged
merged 4 commits into from
May 29, 2020
Merged

Add property key descriptions to breakdown filter #886

merged 4 commits into from
May 29, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented May 28, 2020

Changes

  • Added descriptions to breakdown filter
  • Changed "paths" to "URL" to avoid confusion
  • Give full date when hovering over

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl requested a review from EDsCODE May 28, 2020 11:04
@timgl timgl temporarily deployed to posthog-breakdown-prope-dshsxp May 28, 2020 11:05 Inactive
@jamesefhawkins
Copy link
Collaborator

Thanks. This closes #884

EDsCODE
EDsCODE requested changes May 28, 2020
View reviewed changes
frontend/src/lib/components/PropertyKeyInfo.js Outdated
label: '$ce_version',
description: '',
label: 'Anon Distinct ID',
description: 'If the user ',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you didn't finish the description here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Fixed

@timgl timgl temporarily deployed to posthog-breakdown-prope-dshsxp May 29, 2020 11:06 Inactive
EDsCODE
EDsCODE approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! that event table change may have to be resolved when #895 is merged

@timgl timgl temporarily deployed to posthog-breakdown-prope-dshsxp May 29, 2020 16:19 Inactive
@timgl
Copy link
Collaborator Author

timgl commented May 29, 2020

Yep just removed those, will wait for tests then merge

@EDsCODE EDsCODE merged commit ce00a3c into master May 29, 2020
@EDsCODE EDsCODE deleted the breakdown-property-key-descriptions branch May 29, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timgl @jamesefhawkins @EDsCODE