Add Django-debug-toolbar for profiling requests performance #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
reviewed
May 14, 2020
requirements.txt
Outdated
| @@ -82,4 +82,4 @@ wcwidth==0.1.9 | |||
| Werkzeug==1.0.0 | |||
| whitenoise==5.0.1 | |||
| zipp==3.1.0 | |||
|
|
|||
| django-debug-toolbar==2.2 | |||
There was a problem hiding this comment.
Would be good to move this into requirements/dev.in and compile it with pip-compile requirements/dev.in
timgl
reviewed
May 14, 2020
posthog/settings.py
Outdated
| @@ -85,7 +85,8 @@ def get_env(key): | |||
| 'rest_framework', | |||
| 'loginas', | |||
| 'corsheaders', | |||
| 'social_django' | |||
| 'social_django', | |||
| 'debug_toolbar' | |||
There was a problem hiding this comment.
b/c of the below comment, this package won't always be here. Could do something like
try:
import debug_toolbar
INSTALLED_APPS.append('debug_toolbar')
MIDDLEWARE.append('debug_toolbar.middleware.DebugToolbarMiddleware')
except ImportError:
pass
timgl
reviewed
May 18, 2020
posthog/urls.py
Outdated
| @@ -180,11 +180,14 @@ def logout(request): | |||
| ] | |||
|
|
|||
| if settings.DEBUG: | |||
| import debug_toolbar # type: ignore | |||
There was a problem hiding this comment.
This should probably have the same try/except pattern in case someone uses DEBUG to debug live and hasn't installed debug_toolbarr
posthog/settings.py
Outdated
|
|
||
| # Load debug_toolbar if we can (DEBUG and Dev modes) | ||
| try: | ||
| import debug_toolbar # type: ignore |
There was a problem hiding this comment.
Might be easier to just add the module to mypy.ini
timgl
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Really helps figure out what Django is trying to do on the backend and if it's the DB that's the problem or the app.
This is only enabled when
DEBUGis TrueChecklist