Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1936 retention graph #2578

Merged
merged 47 commits into from
Dec 1, 2020
Merged

1936 retention graph #2578

merged 47 commits into from
Dec 1, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Nov 30, 2020 •
edited
Loading

Changes

Please describe.

  • all the additions of first time retention and multiple events has made the query incredibly slow especially when processing actions
    If this affects the frontend, include screenshots.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

EDsCODE added 30 commits November 16, 2020 13:10
@EDsCODE
intiial graph on PG
ebfd52a
@EDsCODE
initial frontend
9693560
@EDsCODE
merge master
b1deeb3
@EDsCODE
fix filtering and types
2c07234
@EDsCODE
clickhouse working
99c58fd
@EDsCODE
change reference date
801bae4
@EDsCODE
fix label and defaults
27bf714
@EDsCODE
fix multiple event retention
7fd9f2f
@EDsCODE
working clickhouse and postgres for multiple events
5888e26
@EDsCODE
remove final
a5acb99
@EDsCODE
remove sql parse
8c371a8
@EDsCODE
add inital person query
9c91064
@EDsCODE
working clickhouse person query and return testrunner
c20f2e1
@EDsCODE
implement postgres retrieve person
cbd1c46
@EDsCODE
add endpoint and pagianted test
20d024c
@EDsCODE
click on datapoint works
e6af199
@EDsCODE
fix params
a86d2cc
@EDsCODE
fix action handling
d6315ab
@EDsCODE
people paginated backend
182c39d
@EDsCODE
finished paginatino frontend logic
65a0689
@EDsCODE
fix variable naming for pg
3d882bc
@EDsCODE
working first time persons for clickhouse
57347bf
@EDsCODE
first time people working for pg
5100050
@EDsCODE
Merge branch '1936-retention-graph' of github.com:PostHog/posthog int…
1d3d5fa 
…o 1936-retention-graph

* '1936-retention-graph' of github.com:PostHog/posthog:
  first time people working for pg
  working first time persons for clickhouse
  fix variable naming for pg
  finished paginatino frontend logic
  people paginated backend
@EDsCODE
dont replace if recurring
5f1d08a
@EDsCODE
run again
fd18074
@EDsCODE
Merge branch 'master' into 1936-retention-graph
02ba3d7
@EDsCODE
fix import
cae5b47
@EDsCODE
refactor filter to retention specific and move postgres
0cc4a88
@EDsCODE
convert clickhouse to use new filter
13115ed
@timgl timgl temporarily deployed to posthog-1936-retention--3gc048 November 30, 2020 21:47 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented Dec 1, 2020

Note describing what's happening:
The first time retention calculation requires a subquery to look for the earliest time unique users performed an even (with specified properties) across all time. The query is proving to be heavy and it's compounded by complex actions that try to match on many conditions

@EDsCODE
split up retention query
fd5a764
@EDsCODE
Merge branch '1936-retention-graph' of github.com:PostHog/posthog int…
edb8d09 
…o 1936-retention-graph

* '1936-retention-graph' of github.com:PostHog/posthog:
  remove unneded comment and import
@EDsCODE EDsCODE temporarily deployed to posthog-1936-retention--3gc048 December 1, 2020 14:56 Inactive
@EDsCODE
Copy link
Member Author

EDsCODE commented Dec 1, 2020 •
edited
Loading

I split the query so it queries for initial period events separately from the rest of the retention. This will reduce overhead inside the large query where it would have to union a subquery

@EDsCODE EDsCODE marked this pull request as ready for review December 1, 2020 15:04
@EDsCODE EDsCODE mentioned this pull request Dec 1, 2020
Closed
@EDsCODE EDsCODE merged commit 98932d0 into master Dec 1, 2020
@EDsCODE EDsCODE deleted the 1936-retention-graph branch December 1, 2020 15:15
@EDsCODE EDsCODE mentioned this pull request Dec 1, 2020
Closed
@EDsCODE EDsCODE mentioned this pull request Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDsCODE @timgl