Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update person property filtering #2024

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Update person property filtering #2024

merged 4 commits into from
Oct 26, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 26, 2020

Changes

Please describe.

  • fixes cohort queries on clickhouse (the grouping and not operators weren't built correctly)
  • changes the crux of person_property_filtering because the view wasn't working great but this should be better

If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@timgl timgl temporarily deployed to posthog-ch-change-perso-pz0h49 October 26, 2020 10:41 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-ch-change-perso-pz0h49 October 26, 2020 11:13 Inactive
@EDsCODE EDsCODE merged commit 3b217c3 into master Oct 26, 2020
@EDsCODE EDsCODE deleted the ch-change-persons-prop-query branch October 26, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EDsCODE @timgl