Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint rule for empty JSX elements #2023

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Add eslint rule for empty JSX elements #2023

merged 2 commits into from
Oct 26, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

I got tired of seeing the yellow background behind elements like this:

Screenshot 2020-10-26 at 11 31 30

... so I added an eslint rule to prevent these from showing up and fixed the existing ones.

Checklist

  • All querysets/queries filter by Organization, Team, and User (if this PR affects ANY querysets/queries).
  • Django backend tests (if this PR affects the backend).
  • Cypress end-to-end tests (if this PR affects the frontend).

@mariusandra mariusandra requested review from macobo and Twixes October 26, 2020 10:36
@timgl timgl temporarily deployed to posthog-eslint-empty-el-s3p4ok October 26, 2020 10:37 Inactive
@mariusandra
Copy link
Collaborator Author

Thanks @macobo ! Some backend tests are failing that are not related to this PR, so I'll merge anyway.

@mariusandra mariusandra merged commit fccacd6 into master Oct 26, 2020
@mariusandra mariusandra deleted the eslint-empty-elements branch October 26, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

@Twixes Twixes Awaiting requested review from Twixes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusandra @macobo @timgl