Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix session label hover erroring #1874

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Fix session label hover erroring #1874

merged 1 commit into from
Oct 14, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 14, 2020

Changes

Please describe.

  • The session label wasn't appearing on hover because it was erroring. The format label function expects an action but there's not supposed to be an action object for session graphs

If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-fix-session-lab-j0rpdm October 14, 2020 11:11 Inactive
@EDsCODE EDsCODE requested review from timgl and Twixes October 14, 2020 11:14
@Twixes Twixes merged commit 7c02780 into master Oct 14, 2020
@Twixes Twixes deleted the fix-session-label branch October 14, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

@Twixes Twixes Awaiting requested review from Twixes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @timgl @Twixes