Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim quotes on event properties #1852

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Trim quotes on event properties #1852

merged 3 commits into from
Oct 13, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 13, 2020

Changes

Please describe.
If this affects the front-end, include screenshots.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-ch-clean-eventp-mq8kmu October 13, 2020 13:02 Inactive
@EDsCODE EDsCODE temporarily deployed to posthog-ch-clean-eventp-mq8kmu October 13, 2020 13:09 Inactive
macobo
macobo suggested changes Oct 13, 2020
View reviewed changes
ee/clickhouse/models/event.py Outdated Show resolved Hide resolved
ee/clickhouse/models/event.py Outdated Show resolved Hide resolved
@EDsCODE EDsCODE temporarily deployed to posthog-ch-clean-eventp-mq8kmu October 13, 2020 13:25 Inactive
@EDsCODE EDsCODE merged commit 72fe8fd into master Oct 13, 2020
@EDsCODE EDsCODE deleted the ch-clean-eventprops branch October 13, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macobo macobo macobo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @macobo @timgl