Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small insights type update #1717

Merged
merged 4 commits into from
Sep 25, 2020
Merged

Small insights type update #1717

merged 4 commits into from
Sep 25, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

Very random change to fix a few TS errors.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@mariusandra mariusandra requested a review from EDsCODE September 24, 2020 15:22
@timgl timgl temporarily deployed to posthog-typescript-migr-waszvy September 24, 2020 15:23 Inactive
@Twixes Twixes requested a deployment to posthog-typescript-migr-waszvy September 25, 2020 00:15 Abandoned
@Twixes Twixes temporarily deployed to posthog-typescript-migr-waszvy September 25, 2020 00:16 Inactive
Twixes
Twixes approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Also updated posthog-production tests.

@Twixes Twixes removed the request for review from EDsCODE September 25, 2020 00:17
@Twixes Twixes merged commit e9ce195 into master Sep 25, 2020
@Twixes Twixes deleted the typescript-migration branch September 25, 2020 00:20
@Twixes Twixes mentioned this pull request Sep 25, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariusandra @Twixes @timgl