Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade react dom #1559

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Downgrade react dom #1559

merged 1 commit into from
Sep 3, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Sep 3, 2020 •
edited
Loading

Changes

On app, when navigating from a random user to "insights" i get the following error.
image

https://sentry.io/organizations/posthog/issues/1872377025/?project=1899813&query=is%3Aunresolved

I think it's related to react-dom but couldn't reproduce locally

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-downgrade-react-1lzhza September 3, 2020 12:25 Inactive
@timgl timgl requested a review from Twixes September 3, 2020 12:25
@Twixes
Copy link
Member

Twixes commented Sep 3, 2020

Not sure, but we can try.

@Twixes Twixes merged commit b101e42 into master Sep 3, 2020
@Twixes Twixes deleted the downgrade-react-dom branch September 3, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twixes Twixes Awaiting requested review from Twixes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timgl @Twixes