Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify email in frontend #1558

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Identify email in frontend #1558

merged 1 commit into from
Sep 3, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Sep 3, 2020

Changes

In some cases identifying in the backend wasn't working (or was so long ago that we weren't sending the correct information). Doing this in the frontend gives us another failsafe.

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl requested a review from paolodamico September 3, 2020 11:38
@timgl timgl temporarily deployed to posthog-identify-email--vss1mp September 3, 2020 11:41 Inactive
Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs suggest doing

PostHog.people.set({email: user.email});

but this approach might work too.

@timgl timgl merged commit 58b6e43 into master Sep 3, 2020
@timgl timgl deleted the identify-email-in-frontend branch September 3, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants