Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotation popup on hover #1331

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Add annotation popup on hover #1331

merged 2 commits into from
Aug 4, 2020

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Aug 3, 2020

Changes

Addresses #1220

Please describe.
If this affects the front-end, include screenshots.
2020-08-03 10 19 29

Checklist

  • All querysets/queries filter by Team (if this PR affects any querysets/queries)
  • Backend tests (if this PR affects the backend)
  • Cypress E2E tests (if this PR affects the front and/or backend)

@timgl timgl temporarily deployed to posthog-1220-highlight--9u9qtc August 3, 2020 14:21 Inactive
@EDsCODE EDsCODE requested a review from mariusandra August 3, 2020 15:11
@timgl timgl temporarily deployed to posthog-1220-highlight--9u9qtc August 4, 2020 08:47 Inactive
@Twixes
Copy link
Member

Twixes commented Aug 4, 2020 •
edited
Loading

I made the close button a classic X, only appearing if the annotation is locked in place. Better UX this way, I believe.

Close

@timgl timgl merged commit f5a7906 into master Aug 4, 2020
@timgl timgl deleted the 1220-highlight-annotation branch August 4, 2020 13:09
@Twixes Twixes mentioned this pull request Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra Awaiting requested review from mariusandra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EDsCODE @Twixes @timgl