Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ./bin/test command #1074

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Improve ./bin/test command #1074

merged 1 commit into from
Jun 23, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jun 23, 2020

It did not run under fish shell at all, added a shebang to make it
work.

Also it assumed nodemon is installed globally. Instead we can add
nodemon as a devDependency and use npx to run it.

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@macobo
Improve ./bin/test command
d18e747 
It did not run under `fish` shell at all, added a shebang to make it
work.

Also it assumed nodemon is installed globally. Instead we can add
nodemon as a devDependency and use `npx` to run it.
@macobo macobo force-pushed the improve-bin-test branch from 5a31f5a to d18e747 Compare June 23, 2020 16:38
timgl
timgl reviewed Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@timgl timgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@timgl timgl merged commit 596635f into PostHog:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl timgl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macobo @timgl