Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show upgrade warning if using a really old browser #1046

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

mariusandra
Copy link
Collaborator

Changes

In case the user is using a really old browser (tested by checking if it supports Object.entries), we show a warning message asking the user to upgrade.

image

This shows up no matter if the react bundle managed to load or not, as the error could be in initing the bundle for example.

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)
  • Cypress E2E tests (if applicable)

@timgl timgl temporarily deployed to posthog-show-old-browse-dz28nl June 18, 2020 09:05 Inactive
@timgl
Copy link
Collaborator

timgl commented Jun 18, 2020

Thanks for that!

@timgl timgl merged commit e4a9acc into master Jun 18, 2020
@timgl timgl deleted the show-old-browser-message branch June 18, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants