Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long href inserts #1027

Merged
merged 5 commits into from
Jun 16, 2020
Merged

Fix long href inserts #1027

merged 5 commits into from
Jun 16, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Jun 16, 2020

Changes

  • Increase max length of href to 2048
  • Truncate if still longer than that

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)

@timgl timgl requested a review from mariusandra June 16, 2020 07:58
@timgl timgl temporarily deployed to posthog-fix-long-href-i-ugg2lc June 16, 2020 07:59 Inactive
@mariusandra
Copy link
Collaborator

Looks good

@mariusandra mariusandra merged commit 5201fab into master Jun 16, 2020
@mariusandra mariusandra deleted the fix-long-href-inserts branch June 16, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusandra mariusandra mariusandra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timgl @mariusandra