Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make paths work for Events, not just pageviews #448

Closed
timgl opened this issue Apr 4, 2020 · 1 comment
Closed

Make paths work for Events, not just pageviews #448

timgl opened this issue Apr 4, 2020 · 1 comment
Assignees

Comments

@timgl
Copy link
Collaborator

timgl commented Apr 4, 2020

Is your feature request related to a problem? Please describe.

It'd be great if paths were generic.

There's 4 types of events we care about in paths

  • $pageview, deduplicated on $current_url
  • $screen, deduplicated on $screen
  • $autocapture, deduplicated on elements_hash
  • Anything that doesn't start with $, deduplicated on event name

It'd be great to show a combination of all four, or be able to tick on/off each individual category.

(not for this ticket, but worth keeping in mind:) ability to select a 'starting position', like a pageview with certain current_url.

@timgl timgl added the Savvy label Apr 4, 2020
@EDsCODE EDsCODE self-assigned this Apr 28, 2020
@timgl timgl changed the title Make paths work for Actions, not just pageviews Make paths work for Events, not just pageviews Apr 29, 2020
@EDsCODE
Copy link
Member

EDsCODE commented Apr 29, 2020

One more point to note that I may work into the related PR is that autocapture tags can be really sparsely detailed. " with text "sign up"" could be a label that happens across a sign up flow so without page context a user would be pretty confused what " with text "sign up"" => " with text "sign up"" => " with text "sign up"" event means

@EDsCODE EDsCODE mentioned this issue May 4, 2020
2 tasks
EDsCODE added a commit that referenced this issue May 4, 2020
EDsCODE added a commit that referenced this issue May 18, 2020
timgl pushed a commit that referenced this issue May 18, 2020
* generalized path type

* generalized path type

* naive implementation

* ui

* add custom field

* moved function

* use lateral join for tag elements

* add regex for custom event condition

* add optional type

* add tests and make adjustments

* updated paths to use new paths query

* add full DOM display

* changed dom tree view to modal

* adjust modal settings
@EDsCODE EDsCODE closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants