Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fungibles API #433

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix fungibles API #433

merged 1 commit into from
Jan 16, 2025

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Dec 11, 2024

What?

  • The fungibles API should return the universally recognized Location of an asset, and not where its stored locally.
    For example, if a parachain holds DOT in their assets pallet, the fungibles API should return the id of DOT as (parents: 1, interior: Here), and not the internal location of the assets pallet.

  • For this we should change the id used for foreign assets to be this universal id, and not a u32.

Why?

  • Wallets will start using this API, and it needs to behave as expected.
  • We want to use this API when writing multichain chopsticks e2e tests.

Testing?

In the intergration tests

@JuaniRios JuaniRios mentioned this pull request Dec 11, 2024
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch 2 times, most recently from c77b9ae to 6a91141 Compare December 17, 2024 11:06
@JuaniRios JuaniRios force-pushed the 11-29-weth_oracle_support branch from aec984b to 8b35dc0 Compare December 20, 2024 13:49
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 6a91141 to 1278fab Compare December 20, 2024 13:49
@JuaniRios JuaniRios marked this pull request as ready for review January 6, 2025 13:09
@JuaniRios JuaniRios requested a review from lrazovic January 6, 2025 13:09
Copy link

graphite-app bot commented Jan 6, 2025

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (01/06/25)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 11-29-weth_oracle_support branch from 8b35dc0 to f6e9c8a Compare January 10, 2025 11:49
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch 2 times, most recently from 62e8291 to c88d1c7 Compare January 10, 2025 14:29
@lrazovic lrazovic requested a review from vstam1 January 14, 2025 10:41
runtimes/polimec/src/lib.rs Show resolved Hide resolved
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I leave a deeper XCM config review to @vstam1

@lrazovic lrazovic force-pushed the 11-29-weth_oracle_support branch from f6e9c8a to ca68da1 Compare January 15, 2025 13:00
@lrazovic lrazovic force-pushed the 12-11-fix_fungibles_api branch from c88d1c7 to 42e832c Compare January 15, 2025 13:00
@JuaniRios JuaniRios force-pushed the 11-29-weth_oracle_support branch from ca68da1 to f6e9c8a Compare January 15, 2025 13:03
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 42e832c to c88d1c7 Compare January 15, 2025 13:03
@JuaniRios JuaniRios force-pushed the 11-29-weth_oracle_support branch from f6e9c8a to 68bcca2 Compare January 16, 2025 09:47
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from c88d1c7 to 8bcb321 Compare January 16, 2025 09:47
@JuaniRios JuaniRios force-pushed the 11-29-weth_oracle_support branch from 68bcca2 to 0e300ca Compare January 16, 2025 10:27
Copy link
Contributor Author

JuaniRios commented Jan 16, 2025

Merge activity

  • Jan 16, 7:09 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 7:18 AM EST: Graphite couldn't merge this pull request because a downstack PR WETH from AssetHub support #427 failed to merge.
  • Jan 16, 7:30 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 16, 7:32 AM EST: Graphite rebased this pull request as part of a merge.
  • Jan 16, 7:33 AM EST: A user merged this pull request with Graphite.

@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 21cd51a to c51fd70 Compare January 16, 2025 12:24
@JuaniRios JuaniRios changed the base branch from 11-29-weth_oracle_support to main January 16, 2025 12:24
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from c51fd70 to 43e9d12 Compare January 16, 2025 12:29
@JuaniRios JuaniRios changed the base branch from main to 11-29-weth_oracle_support January 16, 2025 12:29
@JuaniRios JuaniRios changed the base branch from 11-29-weth_oracle_support to graphite-base/433 January 16, 2025 12:30
@JuaniRios JuaniRios changed the base branch from graphite-base/433 to main January 16, 2025 12:30
@JuaniRios JuaniRios force-pushed the 12-11-fix_fungibles_api branch from 43e9d12 to 0f183be Compare January 16, 2025 12:31
@JuaniRios JuaniRios merged commit be29ebd into main Jan 16, 2025
1 check passed
@JuaniRios JuaniRios deleted the 12-11-fix_fungibles_api branch January 16, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants