forked from ckeditor/ckeditor4
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync stable branch from CKEditor4 to our fork #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent throwing error when partially selected widget is copied
Disable PfLO in IE 11
…eclared colors from configuration option.
Expose colorbutton#select method
Fix failing test tests/core/creators/themedui
Tableresize not working when editor placed in container with higher z-index values
Fix widget plugin when switching to source mode via custom keystroke.
Ignore unsupported browsers for emoji manual test
Ignore unsupported mobile manual tests
bocribbz
reviewed
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to stay a sane person so im not going to do a code review for 5000+ files.
Since there are no custom changes. Since this was probably reviewed for the main ckeditor repo by the ckeditor contributors, i'd be ok with merging it in if we do need it.
bocribbz
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/~https://github.com/ckeditor/ckeditor4
We need to sync this branch with our repo to be able to update our working copy
There are no custom changes.