Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftUI Home - Prevent crash if slates don't load #1130

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Dec 13, 2024

Goal

  • Add fail safe to arrays in SlateView if slates only load partial (or no) data

Test Steps

  • Home should not crash

…t contain all the recommendations (e.g. for a fetch error)
@Gio2018 Gio2018 added bug Something isn't working Home labels Dec 13, 2024
@Gio2018 Gio2018 self-assigned this Dec 13, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner December 13, 2024 20:53
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 35.5%
📖 Checking XCode Environment Variables
📖 Edited 1 files
📖 Created 0 files

PocketKit: Coverage: 59.87

File Coverage
SlateView.swift 100.0%

PocketKitTests: Coverage: 22.82

File Coverage
SlateView.swift 94.12%

Generated by 🚫 Danger Swift against 7b80db5

@Gio2018 Gio2018 merged commit da7dc5b into develop Dec 13, 2024
5 of 8 checks passed
@Gio2018 Gio2018 deleted the POCKET-10898-slateview-fail-safe branch December 13, 2024 21:12
Copy link

sentry-io bot commented Dec 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ EXC_BREAKPOINT: Exception 6, Code 1, Subcode 4365258732 > range View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Home
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants