Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics: add Home, Saves, Archives and Reader impressions #1120

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Analytics: add Home, Saves, Archives and Reader impressions #1120

merged 2 commits into from
Nov 20, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Nov 20, 2024

Goal

  • Add screen impression events for Home, Saves/Archive and Reader(article) screens

Test Steps

  • run and check for the events in the console
  • test both UIKit and SwiftUI Home(s)

@Gio2018 Gio2018 added this to the 8.22.0 milestone Nov 20, 2024
@Gio2018 Gio2018 self-assigned this Nov 20, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner November 20, 2024 20:39
@Gio2018 Gio2018 merged commit d187483 into develop Nov 20, 2024
1 check failed
@Gio2018 Gio2018 deleted the POCKET-10871-screen-impressions branch November 20, 2024 20:42
@sentry-io Sentry.io
Copy link

sentry-io bot commented Nov 26, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ App Hanging: App hanging for at least 2000 ms. HomeViewController View Issue
  • ‼️ App Hanging: App hanging for at least 2000 ms. HomeViewController View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassrock bassrock bassrock approved these changes

Assignees

@Gio2018 Gio2018

Labels
analytics
Projects
None yet
Milestone
8.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gio2018 @bassrock